pitrou commented on code in PR #50451:
URL: https://github.com/apache/arrow/pull/50451#discussion_r3615033658
##########
r/src/r_to_arrow.cpp:
##########
@@ -390,12 +391,12 @@ struct RConvert {
return static_cast<float>(from);
}
- // ---- convert to half float: not implemented
+ // ---- convert to half float
template <typename Type, typename From>
static enable_if_t<std::is_same<Type, const HalfFloatType>::value,
Result<typename Type::c_type>>
Convert(Type*, From from) {
- return Status::Invalid("Cannot convert to Half Float");
Review Comment:
My point is that float32s and float64s are weird too, so it seems a bit
weird to special-case float16 in the name of shielding the user from the
weirdness :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
