jonkeane commented on code in PR #50451:
URL: https://github.com/apache/arrow/pull/50451#discussion_r3558817323
##########
r/src/r_to_arrow.cpp:
##########
@@ -390,12 +391,12 @@ struct RConvert {
return static_cast<float>(from);
}
- // ---- convert to half float: not implemented
+ // ---- convert to half float
template <typename Type, typename From>
static enable_if_t<std::is_same<Type, const HalfFloatType>::value,
Result<typename Type::c_type>>
Convert(Type*, From from) {
- return Status::Invalid("Cannot convert to Half Float");
Review Comment:
I'm surprised we didn't get this error when someone tried this. Any ideas
why this didn't bonk? It's not super important for us here since we have now
implemented this, but I am worried there might be other things that we have
that are supposed to bonk like this but actually aren't 😬
##########
r/tests/testthat/test-chunked-array.R:
##########
Review Comment:
Do we need a line like this to actually test the roundtripping?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
