lidavidm commented on code in PR #4499:
URL: https://github.com/apache/arrow-adbc/pull/4499#discussion_r3557473176
##########
c/driver/postgresql/copy/writer.h:
##########
@@ -750,10 +830,42 @@ class PostgresCopyTimestampFieldWriter : public
PostgresCopyFieldWriter {
static inline ArrowErrorCode MakeCopyFieldWriter(
struct ArrowSchema* schema, struct ArrowArrayView* array_view,
const PostgresTypeResolver& type_resolver,
- std::unique_ptr<PostgresCopyFieldWriter>* out, ArrowError* error) {
+ std::unique_ptr<PostgresCopyFieldWriter>* out, ArrowError* error,
+ const PostgresType* target_type = nullptr) {
Review Comment:
nit: we try to keep output parameters at the end; ideally target_type would
go before `out` and `error`
##########
c/driver/postgresql/statement.cc:
##########
@@ -479,8 +485,50 @@ AdbcStatusCode PostgresStatement::CreateBulkTable(const
std::string& current_sch
create += " " + pg_type.sql_type_name();
}
- if (ingest_.mode == IngestMode::kAppend) {
+ auto resolve_copy_target_types = [&]() -> AdbcStatusCode {
Review Comment:
nit: does this need to be a lambda or can it be factored into a proper
method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
