Mandukhai-Alimaa commented on code in PR #4499:
URL: https://github.com/apache/arrow-adbc/pull/4499#discussion_r3562699995
##########
c/driver/postgresql/copy/writer.h:
##########
@@ -922,7 +1033,7 @@ static inline ArrowErrorCode MakeCopyFieldWriter(
std::unique_ptr<PostgresCopyFieldWriter> child_writer;
NANOARROW_RETURN_NOT_OK(MakeCopyFieldWriter(schema->children[0],
array_view->children[0],
type_resolver,
- &child_writer, error));
+ nullptr, &child_writer,
error));
Review Comment:
Shouldn’t we propagate the target child type here instead of passing
nullptr? Otherwise, a case like `LIST<INT64> -> NUMERIC[]` still seems to
choose the child writer and array element OID from the source Arrow type rather
than the destination PostgreSQL element type. We should probably add a test for
this case as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
