BOKJUNSOO commented on code in PR #4499:
URL: https://github.com/apache/arrow-adbc/pull/4499#discussion_r3564376080
##########
c/driver/postgresql/copy/writer.h:
##########
@@ -922,7 +1033,7 @@ static inline ArrowErrorCode MakeCopyFieldWriter(
std::unique_ptr<PostgresCopyFieldWriter> child_writer;
NANOARROW_RETURN_NOT_OK(MakeCopyFieldWriter(schema->children[0],
array_view->children[0],
type_resolver,
- &child_writer, error));
+ nullptr, &child_writer,
error));
Review Comment:
Thanks for pointing this out. I reproduced the issue: PostgreSQL rejected
element OID 20 (bigint) where OID 1700 (numeric) was expected. I updated the
list writer to propagate the target child type to both the child writer and the
array element OID, while retaining the source-derived fallback when no target
type is available. I also added an end-to-end `LIST<INT64> -> NUMERIC[]` append
test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
