hhhizzz commented on PR #10141: URL: https://github.com/apache/arrow-rs/pull/10141#issuecomment-5100674024
> was this PR still considered an API change? i took a brief look and noticed: > > * `RowSelection` no longer implements `Debug`, `Eq` and `PartialEq` > * `RowSelection::iter` return changed from `impl Iterator<Item = &RowSelector>` to `RowSelectionIter<'_>` > > i think both are these are considered breaking changes Hi,@Jefffrey ,`RowSelection` still implements `Debug`, `PartialEq`, and `Eq`; they were changed from derives to manual implementations. The `iter()` signature did change syntactically, but exposing a concrete type that preserves the previously promised `Iterator<Item = &RowSelector>` contract is source-compatible for existing callers. It does create a new concrete-type commitment going forward, though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
