Jefffrey commented on PR #10141: URL: https://github.com/apache/arrow-rs/pull/10141#issuecomment-5100991012
> they were changed from derives to manual implementations thanks i missed that > The `iter()` signature did change syntactically, but exposing a concrete type that preserves the previously promised `Iterator<Item = &RowSelector>` contract is source-compatible for existing callers. It does create a new concrete-type commitment going forward, though. thoughts on if we should revert to the old signature (if possible) just to be on the safe side? i think only really niche use cases would be broken but maybe its good to keep flexibility if ever we need it 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
