pitrou commented on code in PR #50687:
URL: https://github.com/apache/arrow/pull/50687#discussion_r3667691487


##########
python/pyarrow/_flight.pyx:
##########
@@ -2887,6 +2887,7 @@ cdef class _FlightServerFinalizer(_Weakrefable):
                     status = server.Wait()
             check_flight_status(status)
         finally:
+            server.ReleasePythonServerRef()

Review Comment:
   Are you sure this actually works? `finalize` is only called when the Python 
`FlightServerBase` object has been destroyed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to