pitrou commented on code in PR #50687:
URL: https://github.com/apache/arrow/pull/50687#discussion_r3667701888
##########
python/pyarrow/_flight.pyx:
##########
@@ -3234,6 +3235,7 @@ cdef class FlightServerBase(_Weakrefable):
raise ValueError("shutdown() on uninitialized FlightServerBase")
with nogil:
check_flight_status(self.server.get().Shutdown())
+ self.server.get().ReleasePythonServerRef()
Review Comment:
Also, I'm curious: why have a C++ method that releases the Python ref,
instead of simply releasing the `shared_ptr` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
