rok commented on a change in pull request #10334:
URL: https://github.com/apache/arrow/pull/10334#discussion_r633762873
##########
File path: r/tests/testthat/test-Array.R
##########
@@ -291,6 +291,17 @@ test_that("Timezone handling in Arrow roundtrip
(ARROW-3543)", {
expect_identical(read_feather(feather_file), df)
})
+test_that("strptime", {
+ # array of strings
+ time_strings <- Array$create(c("2018-10-07 19:04:05", NA))
+ # array of timestamps (doesn't work if tz="" is added!)
Review comment:
If I understand correctly [system
strptime](https://man7.org/linux/man-pages/man3/strptime.3.html) is used so
`%Z` or `%z` would work. E.g.: `2020-01-01 23:23:14 Europe/Amsterdam` would be
captured by `format = "%Y-%m-%d %H:%M:%S %Z"`.
Capturing timezones would be great IMO but I would listen to Joris here for
sure :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
