rok commented on a change in pull request #10334:
URL: https://github.com/apache/arrow/pull/10334#discussion_r634342467



##########
File path: r/tests/testthat/test-Array.R
##########
@@ -291,6 +291,17 @@ test_that("Timezone handling in Arrow roundtrip 
(ARROW-3543)", {
   expect_identical(read_feather(feather_file), df)
 })
 
+test_that("strptime", {
+  # array of strings
+  time_strings <- Array$create(c("2018-10-07 19:04:05", NA))
+  # array of timestamps (doesn't work if tz="" is added!)

Review comment:
       I've created 
[ARROW-12820](https://issues.apache.org/jira/browse/ARROW-12820) and referenced 
this discussion.
   In context of this issue we could leave a reference to ARROW-12820 in the 
tests and postpone the timezone functionally?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to