nealrichardson commented on a change in pull request #10334:
URL: https://github.com/apache/arrow/pull/10334#discussion_r635544090
##########
File path: r/R/compute.R
##########
@@ -286,3 +286,8 @@ cast_options <- function(safe = TRUE, ...) {
)
modifyList(opts, list(...))
}
+
+strptime_arrow <- function(..., format, unit){
Review comment:
What I was suggesting was
```r
nse_funcs$strptime <- function(x, format = "%Y-%m-%d %H:%M:%S", tz = "",
unit = "ms") {
}
```
following the model of the other functions there that build Expressions. And
if `tz` is not supported somehow, we `stop()` if `tz` is provided.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
