HuaHuaY commented on code in PR #50926:
URL: https://github.com/apache/arrow/pull/50926#discussion_r3851760069
##########
cpp/src/arrow/csv/converter.cc:
##########
@@ -534,8 +534,9 @@ class NullConverter : public ConcreteConverter {
int32_t col_index) override {
NullBuilder builder(pool_);
- auto visit = [&](const uint8_t* data, uint32_t size, bool quoted) ->
Status {
- if (ARROW_PREDICT_TRUE(decoder_.IsNull(data, size, quoted))) {
+ auto visit = [&](const uint8_t* data, uint32_t size, bool quoted,
+ bool missing) -> Status {
+ if (missing || ARROW_PREDICT_TRUE(decoder_.IsNull(data, size, quoted))) {
Review Comment:
I think this is in line with expectations. The data size used for schema
inference can be adjusted via the `block_size` option in `ReadOptions`(though
the data size used for schema inference is not exactly the same as
`block_size`, as there are several branching conditions involved).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
