pitrou commented on code in PR #50926:
URL: https://github.com/apache/arrow/pull/50926#discussion_r3861193962
##########
cpp/src/arrow/csv/reader.cc:
##########
@@ -622,7 +622,8 @@ class ReaderMixin {
column_names_ = GenerateColumnNames(parser.num_cols());
} else {
// Read column names from header row
- auto visit = [&](const uint8_t* data, uint32_t size, bool quoted) ->
Status {
+ auto visit = [&](const uint8_t* data, uint32_t size, bool quoted,
+ bool missing) -> Status {
column_names_.emplace_back(reinterpret_cast<const char*>(data),
size);
Review Comment:
Do we want to assert that `missing` is false?
##########
cpp/src/arrow/csv/parser_test.cc:
##########
@@ -91,7 +91,8 @@ void GetColumn(const BlockParser& parser, int32_t col_index,
std::vector<std::string>* out, std::vector<bool>* out_quoted =
nullptr) {
std::vector<std::string> values;
std::vector<bool> quoted_values;
- auto visit = [&](const uint8_t* data, uint32_t size, bool quoted) -> Status {
+ auto visit = [&](const uint8_t* data, uint32_t size, bool quoted,
+ bool missing) -> Status {
Review Comment:
Do we want to test something about `missing` here? Usually it should be
false.
##########
cpp/src/arrow/csv/parser_test.cc:
##########
@@ -109,7 +110,8 @@ void GetLastRow(const BlockParser& parser,
std::vector<std::string>* out,
std::vector<bool>* out_quoted = nullptr) {
std::vector<std::string> values;
std::vector<bool> quoted_values;
- auto visit = [&](const uint8_t* data, uint32_t size, bool quoted) -> Status {
+ auto visit = [&](const uint8_t* data, uint32_t size, bool quoted,
+ bool missing) -> Status {
Review Comment:
Same here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
