HuaHuaY commented on PR #50926: URL: https://github.com/apache/arrow/pull/50926#issuecomment-5475765338
> > Therefore, I opted for the simple solution of temporarily disabling this newly added flag. > > Wouldn't it be better to return `Status::NotImplemented` to signal that the option is not supported? I intend for the newly added flag in this situation to still be usable for filling in missing columns in the data; it simply shouldn't fill in the header row of the CSV. In the CSV reader, when the user does not explicitly provide column names, the number of columns is determined by the first row after skipping `skip_rows` (meaning that if the file contains a header row, the count reflects the number of column names). However, in the dataset reader, `skip_rows` is not processed upfront, causing the column count to be determined before the file's header row is parsed (a behavior I think strange and likely indicative of an imperfect earlier implementation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
