Copilot commented on code in PR #50990: URL: https://github.com/apache/arrow/pull/50990#discussion_r3874085820
########## cpp/src/parquet/encryption/local_wrap_kms_client.cc: ########## @@ -17,8 +17,8 @@ #include <string_view> -#include "arrow/json/json_writer_internal.h" #include "arrow/json/object_parser.h" +#include "arrow/util/json_writer_internal.h" #include "arrow/util/secure_string.h" Review Comment: Parquet encryption still depends on arrow::json::internal::ObjectParser (from arrow/json/object_parser.h), but its implementation (json/object_parser.cc) is only compiled when ARROW_JSON is enabled (cpp/src/arrow/CMakeLists.txt ARROW_JSON block). With ARROW_JSON=OFF + PARQUET_REQUIRE_ENCRYPTION=ON (or Meson openssl_dep.found()), this will likely introduce new undefined references even after moving JsonWriter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
