pitrou commented on code in PR #50990:
URL: https://github.com/apache/arrow/pull/50990#discussion_r3892832538
##########
cpp/src/arrow/util/simdjson_internal.h:
##########
@@ -94,121 +94,30 @@ Result<T>
ResolveSimdjsonResult(simdjson::simdjson_result<T> result,
return value;
}
-inline const char* JsonTypeName(simdjson::dom::element_type type) {
- switch (type) {
- case simdjson::dom::element_type::ARRAY:
- return "array";
- case simdjson::dom::element_type::OBJECT:
- return "object";
- case simdjson::dom::element_type::INT64:
- case simdjson::dom::element_type::UINT64:
- case simdjson::dom::element_type::DOUBLE:
- return "number";
- case simdjson::dom::element_type::STRING:
- return "string";
- case simdjson::dom::element_type::BOOL:
- return "boolean";
- case simdjson::dom::element_type::NULL_VALUE:
- return "null";
- default:
- return "unknown";
- }
-}
+ARROW_EXPORT const char* JsonTypeName(simdjson::dom::element_type type);
Review Comment:
+1, thanks for taking care of this :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
