wgtmac commented on code in PR #50990:
URL: https://github.com/apache/arrow/pull/50990#discussion_r3878497262
##########
cpp/src/parquet/encryption/local_wrap_kms_client.cc:
##########
@@ -17,8 +17,8 @@
#include <string_view>
-#include "arrow/json/json_writer_internal.h"
#include "arrow/json/object_parser.h"
+#include "arrow/util/json_writer_internal.h"
#include "arrow/util/secure_string.h"
Review Comment:
This seems to be a blocking issue.
##########
cpp/src/arrow/util/CMakeLists.txt:
##########
@@ -87,6 +87,14 @@ add_arrow_test(utility-test
EXTRA_LINK_LIBS
${ARROW_UTILITY_TEST_LINK_LIBS})
+if(ARROW_WITH_SIMDJSON)
+ add_arrow_test(json-writer-internal-test
+ SOURCES
+ json_writer_internal_test.cc
+ EXTRA_LINK_LIBS
+ simdjson::simdjson)
Review Comment:
```
if(SIMDJSON_VENDORED)
add_library(arrow::simdjson ALIAS simdjson)
else()
add_library(arrow::simdjson ALIAS simdjson::simdjson)
endif()
```
It seems better to use arrow::simdjson based on the above statements? cc
@kou
##########
cpp/src/arrow/meson.build:
##########
@@ -224,6 +240,14 @@ arrow_util_srcs = [
arrow_util_deps = [threads_dep]
+if needs_simdjson
+ arrow_util_srcs += [
+ 'util/json_writer_internal.cc',
Review Comment:
Meson can still compile Parquet encryption with JSON disabled, but
json/object_parser.cc remains excluded because needs_json is false. Please
build ObjectParser under the same simdjson gate, otherwise this configuration
still fails to link.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
