rok commented on code in PR #50990:
URL: https://github.com/apache/arrow/pull/50990#discussion_r3895143871
##########
cpp/src/parquet/encryption/key_material.h:
##########
@@ -86,8 +82,7 @@ class PARQUET_EXPORT KeyMaterial {
static KeyMaterial Parse(const std::string& key_material_string);
- static KeyMaterial Parse(
- const ::arrow::json::internal::ObjectParser* key_material_json);
+ static KeyMaterial Parse(const ::arrow::internal::JsonObjectParser*
key_material_json);
Review Comment:
Looking into this further `KeyMaterial::Parse(const ObjectParser*)` was
present in this API since the start. Changing `ObjectParser` etc would change
it. @pitrou what's your opinion on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
