Copilot commented on code in PR #50990:
URL: https://github.com/apache/arrow/pull/50990#discussion_r3894713028
##########
cpp/src/parquet/encryption/key_material.h:
##########
@@ -86,8 +82,7 @@ class PARQUET_EXPORT KeyMaterial {
static KeyMaterial Parse(const std::string& key_material_string);
- static KeyMaterial Parse(
- const ::arrow::json::internal::ObjectParser* key_material_json);
+ static KeyMaterial Parse(const ::arrow::internal::JsonObjectParser*
key_material_json);
Review Comment:
This public overload now exposes `JsonObjectParser`, but its only definition
is in `simdjson_internal.h`, which is not installed (CMake excludes
`*internal*` headers and Meson's util install list omits it). Previously the
installed `object_parser.h` defined the parameter type, so installed clients
can no longer use this overload and existing source clients lose that
header/API. Keep the parser-based helper private/internal, or provide an
installed compatibility/public parser API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
