rok commented on code in PR #50990:
URL: https://github.com/apache/arrow/pull/50990#discussion_r3895052419
##########
cpp/src/parquet/encryption/key_material.h:
##########
@@ -86,8 +82,7 @@ class PARQUET_EXPORT KeyMaterial {
static KeyMaterial Parse(const std::string& key_material_string);
- static KeyMaterial Parse(
- const ::arrow::json::internal::ObjectParser* key_material_json);
+ static KeyMaterial Parse(const ::arrow::internal::JsonObjectParser*
key_material_json);
Review Comment:
Removed the `KeyMaterial::Parse(const ObjectParser*)` and used
`KeyMaterial::Parse(const std::string&)` directly to avoid exposing
`JsonObjectParser`. I believe the removed overload was not intended to be
exposed externally, though it technically currently was.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
