hsutter commented on code in PR #51270:
URL: https://github.com/apache/arrow/pull/51270#discussion_r3994381758
##########
cpp/src/arrow/adapters/orc/adapter.cc:
##########
@@ -135,7 +135,7 @@ constexpr int64_t kReadRowsBatch = 1000;
class OrcStripeReader : public RecordBatchReader {
public:
OrcStripeReader(std::unique_ptr<liborc::RowReader> row_reader,
- std::shared_ptr<Schema> schema, int64_t batch_size,
MemoryPool* pool)
+ const std::shared_ptr<Schema>& schema, int64_t batch_size,
MemoryPool* pool)
: row_reader_(std::move(row_reader)),
schema_(schema),
Review Comment:
I would repeat the same considerations as in my reply about `GatedNode`... I
try to make the case that (minor) adding a `std::move` is slightly less
performance and (major) it's less simple/maintainable. Does that position seem
reasonable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
