hsutter commented on PR #51270: URL: https://github.com/apache/arrow/pull/51270#issuecomment-5646006241
@rok: Aha, thanks -- time for me to quote Homer and say, "D'oh! Always-retain semantics and rvalue arguments." I'll close this again and go rework. Yes, I was missing the issue of rvalue arguments and sink functions. So what I told Claude is not consistent with what I teach: <img width="1398" height="139" alt="image" src="https://github.com/user-attachments/assets/6bc480da-a238-4bb1-8558-6b2791808cc0"; /> Thanks for your patience pointing out this thinko. I had that in an earlier version of the skill and didn't notice I'd removed it, which was a silly error on my part and I should have remembered it here. (Side note: This is a case where I wish C++ had more automatic move-from-definite-last-use of a local variable including a by-value parameter. I still intend to propose that for future C++, and it would help a lot here.) --- Re building cleanly: Locally, I've been doing `cmake --build` in `arrow/cpp`. That seemed to build clean, but I see in the failing jobs there are errors like this that I didn't get in my local build: ``` /arrow/cpp/src/arrow/csv/reader.cc:1222:38: error: no declaration matches 'arrow::Result<std::shared_ptr<arrow::csv::TableReader> > arrow::csv::TableReader::Make(arrow::io::IOContext, const std::shared_ptr<arrow::io::InputStream>&, const arrow::csv::ReadOptions&, const arrow::csv::ParseOptions&, const arrow::csv::ConvertOptions&)' ``` Any ideas why I'm not getting these myself when I build locally? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
