HuaHuaY commented on code in PR #50807:
URL: https://github.com/apache/arrow/pull/50807#discussion_r4003880865
##########
cpp/src/parquet/statistics.h:
##########
@@ -78,6 +77,11 @@ class TypedComparator : public Comparator {
/// \brief Compute maximum and minimum elements in a batch of
/// elements without any nulls
+ ///
+ /// For floating-point types with ColumnOrder::TYPE_DEFINED_ORDER, NaNs are
+ /// ignored. With ColumnOrder::IEEE_754_TOTAL_ORDER, NaNs participate in the
+ /// result. IEEE total-order bounds must not be written directly as Parquet
+ /// statistics, which exclude NaNs when valid bounds exist.
Review Comment:
Yes. Parquet statistics do not allow the presence of `NaN` values when
non-`NaN` values are also present, whereas the return value of this function
may contain `NaN`s.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
