HuaHuaY commented on code in PR #50807:
URL: https://github.com/apache/arrow/pull/50807#discussion_r4003689019
##########
cpp/src/parquet/arrow/reader_internal.cc:
##########
@@ -270,6 +270,15 @@ Status ByteArrayStatisticsAsScalars(const Statistics&
statistics,
return ExtractDecimalMinMaxFromBytes(statistics.EncodeMin(),
statistics.EncodeMax(),
*logical_type, min, max);
}
+ if (logical_type->type() == LogicalType::Type::FLOAT16) {
+ *min = std::make_shared<::arrow::HalfFloatScalar>(
Review Comment:
I think it is more of a fix for incorrect behavior. Previously, float16
statistics were treated as `fixed_size_binary[2]`.
It does not have a standalone unit test, but it is tested in
`TEST(ParquetPageIndex, FloatingPointOrdersInterop)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
