HuaHuaY commented on code in PR #50807:
URL: https://github.com/apache/arrow/pull/50807#discussion_r4003774588
##########
cpp/src/parquet/page_index.h:
##########
@@ -73,6 +73,15 @@ class PARQUET_EXPORT ColumnIndex {
/// available.
virtual const std::vector<int64_t>& null_counts() const = 0;
+ /// \brief Whether per-page NaN count information is available.
+ virtual bool has_nan_counts() const = 0;
+
+ /// \brief An optional vector with the number of NaN values in each data
page.
+ ///
+ /// `has_nan_counts` should be called first to determine if this information
is
+ /// available.
+ virtual const std::vector<int64_t>& nan_counts() const = 0;
+
Review Comment:
I think using `std::span<const int64_t>` may be better, and we can use
`span.empty()` instead of `optional.has_value()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
