pitrou commented on PR #51270: URL: https://github.com/apache/arrow/pull/51270#issuecomment-5664187659
> * arrow/adapters/orc/adapter_test.cc:131, GenerateRandomTimestampArray > * arrow/array/array_dict_test.cc:906, TestDecimalDictionaryBuilderDoubleTableSize > * arrow/array/array_run_end_test.cc:71, RunEndEncodedArrayFromJSON > * arrow/array/diff_test.cc:118, BaseAndTargetFromRandomFilter > * arrow/buffer_test.cc:90, MyMemoryManager ctor Those 5 are in unit tests, so I don't think we care either way. > * arrow/acero/source_node.cc:304, TableSourceNode ctor Hmm, from what I gather, the `std::shared_ptr<Table>` is owned by the `TableSourceNodeOptions` that's supposed to be passed to `TableSourceNode::Make` (which doesn't take ownership). That probably means that the shared_ptr needs to be kept alive at an upper level, and this one can take a const-ref. > * arrow/acero/unmaterialized_table_internal.h:245, AddEntry Similarly, it seems this one can take a const-ref. @taepper and @zanmato1984 might want to take a closer look, as they are more experts on this part of the code than I am. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
