taepper commented on PR #51270: URL: https://github.com/apache/arrow/pull/51270#issuecomment-5664418004
> > * arrow/acero/source_node.cc:304, TableSourceNode ctor > > Hmm, from what I gather, the `std::shared_ptr<Table>` is owned by the `TableSourceNodeOptions` that's supposed to be passed to `TableSourceNode::Make` (which doesn't take ownership). That probably means that the shared_ptr needs to be kept alive at an upper level, and this one can take a const-ref. It seems the `std::shared_ptr<Schema> schema` are missing a `std::move` instead. Agree with your assessment of the `std::shared_ptr<Table>` instances > > * arrow/acero/unmaterialized_table_internal.h:245, AddEntry > > Similarly, it seems this one can take a const-ref. Agree. The changes to [cpp/src/arrow/acero/exec_plan.cc](https://github.com/apache/arrow/pull/51270/changes#diff-70e843181eb977ed11ad131f79a0f54a0bf9e30a0cb752d440658ee0cc16cc34) seem valid whereas [cpp/src/arrow/acero/asof_join_node.cc](https://github.com/apache/arrow/pull/51270/changes#diff-5493b6ae7ea2a4d5cfb581034c076e9c4be7608382168de6d1301ef67b6c01ee) misses a `std::move` instead AFAICT -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
