Copilot commented on code in PR #50195:
URL: https://github.com/apache/arrow/pull/50195#discussion_r4013850367
##########
r/configure:
##########
@@ -358,6 +358,10 @@ add_feature_flags () {
fi
if arrow_built_with ARROW_S3; then
PKG_CFLAGS_FEATURES="$PKG_CFLAGS_FEATURES -DARROW_R_WITH_S3"
+ PKG_CONFIG_NAMES_FEATURES="$PKG_CONFIG_NAMES_FEATURES arrow-s3"
Review Comment:
With a static-only Arrow build, `arrow-s3.pc` declares `Requires: arrow`;
passing `arrow arrow-s3` to pkg-config leaves `-larrow` before `-larrow_s3`.
GNU/MinGW linkers do not rescan an earlier archive, so objects pulled from
`libarrow_s3.a` can leave Arrow symbols unresolved. Please make the pkg-config
path request/reorder `arrow-s3` before `arrow` (and apply the same fix in
`r/configure.win`), as the no-pkg-config fallback already does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
