tadeja commented on code in PR #50195:
URL: https://github.com/apache/arrow/pull/50195#discussion_r4008066509
##########
cpp/src/arrow/filesystem/CMakeLists.txt:
##########
@@ -128,21 +129,17 @@ if(ARROW_S3)
endif()
endif()
- if(ARROW_S3_MODULE AND ARROW_BUILD_TESTS)
+ if(ARROW_BUILD_TESTS AND ARROW_BUILD_SHARED)
add_arrow_test(s3fs_module_test
SOURCES
s3fs_module_test.cc
s3_test_util.cc
EXTRA_LABELS
filesystem
DEFINITIONS
- ARROW_S3_LIBPATH="$<TARGET_FILE:arrow_s3fs>"
+ ARROW_S3_LIBPATH="$<TARGET_FILE:arrow_s3_shared>"
Review Comment:
( total nit for single test build, like in `filesystem-test` )
```suggestion
ARROW_S3_LIBPATH="$<TARGET_FILE:arrow_s3_shared>"
EXTRA_DEPENDENCIES
arrow_s3_shared
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
