raulcd commented on code in PR #50195:
URL: https://github.com/apache/arrow/pull/50195#discussion_r4004257566
##########
c_glib/arrow-glib/meson.build:
##########
@@ -225,6 +225,9 @@ if not gio.found()
gio = dependency('gio-2.0')
endif
dependencies = [arrow_acero, arrow_compute, arrow, gobject, gio]
+if arrow_s3.found()
+ dependencies += arrow_s3
+endif
Review Comment:
This is not a bad point, the lookup succeeds whenever the C++ build has S3,
since the module and its pkg-config / CMake files are installed together;
making arrow-glib work without linking it is the `LoadFileSystemFactories()`
work that will be tackled afterwards. @kou do you think I should do something
on this PR for this or we tackle this on the follow up PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
