sunchao commented on a change in pull request #307:
URL: https://github.com/apache/arrow-rs/pull/307#discussion_r637626054
##########
File path: parquet/src/column/writer.rs
##########
@@ -607,9 +607,11 @@ impl<T: DataType> ColumnWriterImpl<T> {
let max_def_level = self.descr.max_def_level();
let max_rep_level = self.descr.max_rep_level();
+ // always update column NULL count, no matter if page stats are used
+ self.num_column_nulls += self.num_page_nulls;
Review comment:
> which IS updated
(Sorry for the slow response) This is the part I don't quite understand.
`add_data_page` is called in two places: `flush_data_pages` and
`write_mini_batch`. I can see this handles the first case but don't see how it
applies for the second case too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
