crepererum commented on a change in pull request #307:
URL: https://github.com/apache/arrow-rs/pull/307#discussion_r638528226
##########
File path: parquet/src/column/writer.rs
##########
@@ -607,9 +607,11 @@ impl<T: DataType> ColumnWriterImpl<T> {
let max_def_level = self.descr.max_def_level();
let max_rep_level = self.descr.max_rep_level();
+ // always update column NULL count, no matter if page stats are used
+ self.num_column_nulls += self.num_page_nulls;
Review comment:
I'm not sure I follow:
- Is your point that `self.num_column_nulls += self.num_page_nulls;` should
only be triggered during `flush_data_pages`, not during `write_mini_batch`?
- Or is the question under which condition `write_mini_batch` calls
`add_data_page`? For that: As far as I can tell it is NOT called during the
test at least because of `should_add_data_page` decides not to do so (likely
because of the small test case).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
