sunchao commented on a change in pull request #307:
URL: https://github.com/apache/arrow-rs/pull/307#discussion_r638531723
##########
File path: parquet/src/column/writer.rs
##########
@@ -607,9 +607,11 @@ impl<T: DataType> ColumnWriterImpl<T> {
let max_def_level = self.descr.max_def_level();
let max_rep_level = self.descr.max_rep_level();
+ // always update column NULL count, no matter if page stats are used
+ self.num_column_nulls += self.num_page_nulls;
Review comment:
I meant the second: `write_mini_batch` will call `add_data_page` if
encoded data page size exceeds the limit. In this case it seems
`num_page_nulls` and subsequently `num_column_nulls` will not be set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
