AlenkaF commented on code in PR #51404:
URL: https://github.com/apache/arrow/pull/51404#discussion_r4180697962
##########
python/pyarrow/tests/test_pandas.py:
##########
@@ -99,8 +99,8 @@ def _alltypes_example(size=100):
def _check_pandas_roundtrip(df, expected=None, use_threads=False,
expected_schema=None,
- check_dtype=True, schema=None,
- preserve_index=False,
+ check_dtype=True, check_freq=False,
Review Comment:
> But so (AFAIK) `check_freq` _was_ already enabled and verified in most
cases, and only not in the case of eg a MultiIndex or columns Index.
Ah, sorry, my mistake. I misunderstood, the changes do seem to only affect
[columns
index](https://github.com/pandas-dev/pandas/blob/71e11934c88cebded4f633e845cd1a16d27bfbe6/doc/source/whatsnew/v3.1.0.rst#L409)
(I thought it was a general case). Thanks for clarifying!
> But, I think it should also be quite easy to just update the failing test.
Yeah, no problem there! Will update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
