AlenkaF commented on code in PR #51404:
URL: https://github.com/apache/arrow/pull/51404#discussion_r4181076709
##########
python/pyarrow/tests/test_pandas.py:
##########
@@ -5006,7 +5006,7 @@ def test_does_not_mutate_timedelta_dtype():
assert np.dtype(np.timedelta64) == expected
- df = pd.DataFrame({"a": [np.timedelta64()]})
+ df = pd.DataFrame({"a": [np.timedelta64(0, "s")]})
Review Comment:
> `if (type == NPY_DATETIME) {` then both asserts pass - shouldn't that fail?
I am not sure, really, maybe something else in the C++ code changed since
the connected PR making it more stable?
> But with these changes [...] at least second assert does (correctly) fail 🤷
Fails with only `if (type == NPY_DATETIME) {` or with current main?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
