AlenkaF commented on code in PR #51404:
URL: https://github.com/apache/arrow/pull/51404#discussion_r4183348161
##########
python/pyarrow/tests/test_pandas.py:
##########
@@ -5006,7 +5006,7 @@ def test_does_not_mutate_timedelta_dtype():
assert np.dtype(np.timedelta64) == expected
- df = pd.DataFrame({"a": [np.timedelta64()]})
+ df = pd.DataFrame({"a": [np.timedelta64(0, "s")]})
Review Comment:
OK, I think I understand. You are trying to say that `df =
pd.DataFrame({"a": [np.timedelta64(0, "s")]})` would also mutate
`np.dtype(np.timedelta64)` in case of the old, buggy code and so the asserts do
not need to be changed in this PR.
I should test that, yes! Will do so later today, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
