alamb commented on code in PR #11168:
URL: https://github.com/apache/arrow-rs/pull/11168#discussion_r4234367951
##########
parquet/tests/arrow_reader/io/sync_reader.rs:
##########
@@ -221,6 +225,10 @@ fn test_read_limit() {
#[test]
fn test_read_single_row_filter() {
+ // Note: the skip that precedes the selected rows now defers the dictionary
Review Comment:
I think the comment here that explains the changes in this PR will be
confusing in the future
Maybe a comment saying that "DictionaryPages are deferred until first read,
see apache/arrow-rs#11154" would help, but the fact that in the past the
behavior was different is likely not relevant in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
