zhuqi-lucas commented on code in PR #11168:
URL: https://github.com/apache/arrow-rs/pull/11168#discussion_r4237812772
##########
parquet/tests/arrow_reader/io/sync_reader.rs:
##########
@@ -221,6 +225,10 @@ fn test_read_limit() {
#[test]
fn test_read_single_row_filter() {
+ // Note: the skip that precedes the selected rows now defers the dictionary
Review Comment:
Thanks @alamb — agreed, the before/after framing stops meaning anything once
this merges. Reworded all three to state what the reader does, and to explain
the ordering the snapshot actually shows: the dictionary trails the data page
wherever a skip precedes it, and leads it where none does. Issue link kept.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
