HuaHuaY commented on code in PR #51286:
URL: https://github.com/apache/arrow/pull/51286#discussion_r4400315321
##########
cpp/src/arrow/csv/options.h:
##########
@@ -65,6 +65,8 @@ struct ARROW_EXPORT ParseOptions {
bool pad_short_rows = false;
/// Whether rows with more columns than expected should ignore the extra
columns.
bool ignore_extra_columns = false;
+ /// Multi-character field delimiter. If non-empty, overrides `delimiter`.
+ std::string delimiter_string;
Review Comment:
My thinking is that `std::string` could also be used as a parameter for
single characters, so we don't need to use `std::variant`. In my memory, the
reason I didn't deprecate `char delimiter` is that it is still being used by
Python code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
