Copilot commented on code in PR #51286:
URL: https://github.com/apache/arrow/pull/51286#discussion_r4410975207
##########
cpp/src/arrow/csv/options.h:
##########
@@ -65,6 +65,8 @@ struct ARROW_EXPORT ParseOptions {
bool pad_short_rows = false;
/// Whether rows with more columns than expected should ignore the extra
columns.
bool ignore_extra_columns = false;
+ /// Multi-character field delimiter. If non-empty, overrides `delimiter`.
+ std::string delimiter_string;
Review Comment:
`ParseOptions` is an `ARROW_EXPORT` public C++ struct, so adding an inline
`std::string` member changes its size/layout and the generated copy/ABI used by
downstream binaries. This is a binary-breaking API change, but the PR
description does not call it out; please either use an ABI-safe extension
mechanism or explicitly account for the required compatibility/versioning
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
