pitrou commented on code in PR #51286:
URL: https://github.com/apache/arrow/pull/51286#discussion_r4411172801
##########
cpp/src/arrow/csv/parser.cc:
##########
@@ -727,12 +771,14 @@ class BlockParserImpl {
Status Parse(const std::vector<std::string_view>& data, bool is_final,
uint32_t* out_size) {
return internal::DispatchBool(
- [&]<bool Quoting, bool Escaping, bool IgnoreExtraColumns>() {
- using SpecializedOptions = internal::SpecializedOptions<Quoting,
Escaping>;
+ [&]<bool Quoting, bool Escaping, bool IgnoreExtraColumns, bool
MultiDelimiter>() {
+ using SpecializedOptions =
+ internal::SpecializedOptions<Quoting, Escaping, MultiDelimiter>;
return ParseSpecialized<SpecializedOptions,
IgnoreExtraColumns>(data, is_final,
out_size);
},
- options_.quoting, options_.escaping, options_.ignore_extra_columns);
+ options_.quoting, options_.escaping, options_.ignore_extra_columns,
+ !options_.delimiter_string.empty());
Review Comment:
Should we use `options.delimiter_string.size() > 1` instead? When we
deprecate `options.delimiter` this will become important for performance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
