Dandandan commented on a change in pull request #384:
URL: https://github.com/apache/arrow-rs/pull/384#discussion_r642361176
##########
File path: arrow/src/compute/kernels/filter.rs
##########
@@ -59,19 +59,14 @@ pub(crate) struct SlicesIterator<'a> {
}
impl<'a> SlicesIterator<'a> {
- pub(crate) fn new(filter: &'a BooleanArray) -> Self {
+ pub fn new(filter: &'a BooleanArray) -> Self {
let values = &filter.data_ref().buffers()[0];
-
- // this operation is performed before iteration
- // because it is fast and allows reserving all the needed memory
- let filter_count = values.count_set_bits_offset(filter.offset(),
filter.len());
Review comment:
Doesn't this mean that the count is done multiple times now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
