yordan-pavlov commented on a change in pull request #384:
URL: https://github.com/apache/arrow-rs/pull/384#discussion_r644302560
##########
File path: parquet/src/util/mod.rs
##########
@@ -22,6 +22,4 @@ pub mod bit_util;
mod bit_packing;
pub mod cursor;
pub mod hash_util;
-
-#[cfg(test)]
Review comment:
yes, I had to make this change to make
`test_common::page_util::{InMemoryPageIterator, DataPageBuilderImpl,
DataPageBuilder}` available in the benchmark crate; I don't like making this
public either, but haven't been able to find a way to only make it available to
tests and benches; if anyone knows how this could be done I am more than happy
to change it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
