yordan-pavlov commented on a change in pull request #384:
URL: https://github.com/apache/arrow-rs/pull/384#discussion_r644304382
##########
File path: parquet/src/arrow/array_reader.rs
##########
@@ -1499,12 +1499,10 @@ impl<'a> ArrayReaderBuilder {
arrow_type,
)?))
} else {
- let converter = Utf8Converter::new(Utf8ArrayConverter
{});
- Ok(Box::new(ComplexObjectArrayReader::<
- ByteArrayType,
- Utf8Converter,
- >::new(
- page_iterator,
+ use
crate::arrow::arrow_array_reader::{StringArrayConverter, ArrowArrayReader};
Review comment:
the only reason for the local `use` statement is because currently
`ArrowArrayReader` is (intentionally) only used here for strings; once it's
used for more types it would make sense to move most / all of these use
statements to the top.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
