tadeja commented on code in PR #55381:
URL: https://github.com/apache/arrow/pull/55381#discussion_r4478711764
##########
cpp/cmake_modules/SetupCxxFlags.cmake:
##########
@@ -747,6 +747,11 @@ if(CMAKE_SYSTEM_NAME STREQUAL "Emscripten")
"${ARROW_EMSCRIPTEN_LINKER_FLAGS}
-sERROR_ON_WASM_CHANGES_AFTER_LINK=1
-sSTACK_SIZE=${ARROW_EMSCRIPTEN_TEST_STACK_SIZE} -sALLOW_MEMORY_GROWTH
-lnodefs.js -lnoderawfs.js --pre-js
${BUILD_SUPPORT_DIR}/emscripten-test-init.js"
)
endif()
+ # Abseil stack trace via emscripten_stack_snapshot() abort on
Emscripten<4.0.14
+ # if offset converter isn't enabled. Emscripten 4.0.14 removed the offset
converter
+ if(EMSCRIPTEN_VERSION VERSION_LESS "4.0.14")
Review Comment:
You can see the failure there
https://github.com/apache/arrow/pull/55381#issuecomment-6614177482
= after committing [014f1de StrptimeParser fix for preexisting
arrow-utility-test
failure](https://github.com/apache/arrow/commit/014f1de73bc06f68c61eb200d94f3baf64bb17fc)
https://github.com/ursacomputing/crossbow/actions/runs/41708868200/job/126171352370#step:7:4835
<details><summary>Details</summary>
<p>
``` console
[ RUN ] FunctionMapping.ValidCases
Aborted(Cannot use convertFrameToPC (needed by __builtin_return_address)
without -sUSE_OFFSET_CONVERTER)
/build/cpp/debug/arrow-substrait-substrait-test.js:138
throw ex;
^
RuntimeError: Aborted(Cannot use convertFrameToPC (needed by
__builtin_return_address) without -sUSE_OFFSET_CONVERTER). Build with
-sASSERTIONS for more info.
at abort (/build/cpp/debug/arrow-substrait-substrait-test.js:491:11)
at convertFrameToPC
(/build/cpp/debug/arrow-substrait-substrait-test.js:4582:7)
at /build/cpp/debug/arrow-substrait-substrait-test.js:4593:18
at Array.forEach (<anonymous>)
at saveInUnwindCache
(/build/cpp/debug/arrow-substrait-substrait-test.js:4592:17)
at _emscripten_stack_snapshot
(/build/cpp/debug/arrow-substrait-substrait-test.js:4621:7)
at
arrow-substrait-substrait-test.wasm.absl::lts_20260817::GetStackTrace(void**,
int, int)
(wasm://wasm/arrow-substrait-substrait-test.wasm-1625979a:wasm-function[53487]:0x3040e7a)
at arrow-substrait-substrait-test.wasm.absl::lts_20260817::(anonymous
namespace)::GetStack(void**, int)
(wasm://wasm/arrow-substrait-substrait-test.wasm-1625979a:wasm-function[53468]:0x303da31)
at
arrow-substrait-substrait-test.wasm.absl::lts_20260817::synchronization_internal::GraphCycles::UpdateStackTrace(absl::lts_20260817::synchronization_internal::GraphId,
int, int (*)(void**, int))
(wasm://wasm/arrow-substrait-substrait-test.wasm-1625979a:wasm-function[53499]:0x30443c0)
at invoke_vijii
(/build/cpp/debug/arrow-substrait-substrait-test.js:6194:29)
Node.js v24.19.0
Start 85: arrow-substrait-substrait-test
Test #85: arrow-substrait-substrait-test ............***Failed 0.46
sec
```
</p>
</details>
And **no**, the failing `arrow-substrait-substrait-test` couldn't be seen on
CI because it started with #54927 (Abseil bump),
so exactly at the same time as Protobuf CMake configure failure due to the
same PR #54927 (Protobuf bumpf)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
