raulcd commented on code in PR #55381:
URL: https://github.com/apache/arrow/pull/55381#discussion_r4478508279
##########
cpp/cmake_modules/SetupCxxFlags.cmake:
##########
@@ -747,6 +747,11 @@ if(CMAKE_SYSTEM_NAME STREQUAL "Emscripten")
"${ARROW_EMSCRIPTEN_LINKER_FLAGS}
-sERROR_ON_WASM_CHANGES_AFTER_LINK=1
-sSTACK_SIZE=${ARROW_EMSCRIPTEN_TEST_STACK_SIZE} -sALLOW_MEMORY_GROWTH
-lnodefs.js -lnoderawfs.js --pre-js
${BUILD_SUPPORT_DIR}/emscripten-test-init.js"
)
endif()
+ # Abseil stack trace via emscripten_stack_snapshot() abort on
Emscripten<4.0.14
+ # if offset converter isn't enabled. Emscripten 4.0.14 removed the offset
converter
+ if(EMSCRIPTEN_VERSION VERSION_LESS "4.0.14")
Review Comment:
4.0.14 seems to be more than 1 year old. Should we care about older versions?
https://github.com/emscripten-core/emscripten/releases/tag/4.0.14
Was this caught failing on our CI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
