Copilot commented on code in PR #1565:
URL: https://github.com/apache/arrow-go/pull/1565#discussion_r4571173723
##########
parquet/file/column_reader.go:
##########
@@ -674,6 +674,10 @@ func (c *columnChunkReader) skipRows(nrows int64) error {
}
skipped = max(ndefs, skipped)
+ if skipped == 0 {
+ c.err = errNoProgress(min(toSkip,
c.numAvailValues()))
+ return c.err
Review Comment:
The reported `SeekToRow` hang has no regression test. Seeking first
positions and reinitializes the page, which the mock pager's no-op seek does
not exercise. Add a serialized required-page test claiming 10 values but
encoding only 2, and assert that `SeekToRow(5)` returns the short-page error
through both the column reader and `pqarrow.RecordReader`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]