hcrosse commented on code in PR #1565:
URL: https://github.com/apache/arrow-go/pull/1565#discussion_r4571460451
##########
parquet/file/column_reader.go:
##########
@@ -674,6 +674,10 @@ func (c *columnChunkReader) skipRows(nrows int64) error {
}
skipped = max(ndefs, skipped)
+ if skipped == 0 {
+ c.err = errNoProgress(min(toSkip,
c.numAvailValues()))
+ return c.err
Review Comment:
Added `TestSeekToRowPageHoldsFewerValuesThanHeader`, which seeks into a
short required page through a pager that repositions like the real page reader,
and fails through the decoder call limit instead of hanging. I left out a
`pqarrow` test, because a regression there would hang the test binary instead
of failing. `pqarrow`'s `RecordReader.SeekToRow` reaches the same `skipRows`
path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]