zeroshade commented on PR #1565:
URL: https://github.com/apache/arrow-go/pull/1565#issuecomment-6925208019
CI failed here on
`TestReadBatchPageHoldsFewerValuesThanHeader/byte_stream_split`, in the jobs
that run with `-tags noasm`:
```
panic: runtime error: index out of range [0] with length 0
encoding.decodeByteStreamSplitBatchWidth4InByteOrderDefault
byte_stream_split_little_endian.go:42
```
That is an existing bug in the pure Go BYTE_STREAM_SPLIT decoder, which your
test exposes: it panics when asked for zero values, while the AVX2/NEON paths
return early. I missed it in review because I only ran the default build. #1579
fixes the decoder, and with it applied your test passes under `noasm`.
Nothing to change in this PR. Once #1579 is merged, could you rebase onto
main so CI runs against the fix? I'll merge when it's green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]